| Summary: | MeasurementSet should merge last four segments into two if values are identical. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | dewei_zhu | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | NEW --- | ||||||||
| Severity: | Normal | CC: | dewei_zhu, rniwa | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
dewei_zhu
2018-07-03 18:24:37 PDT
Created attachment 344252 [details]
Patch
Comment on attachment 344252 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344252&action=review > Websites/perf.webkit.org/public/v3/models/measurement-set.js:245 > + if (!segmentationSeries.length || value !== segmentationSeries[segmentationSeries.length - 1].value) I think it's cleaner to move this logic to addSegment and rename it to addSegmentMergingIdenticalSegments. The function can then just compare the last value of segmentationSeries and the newly computed value. Created attachment 344271 [details]
Patch
|