Bug 187306

Summary: Remove Strong Confirmation Password button
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebCore Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, ryanhaddad, sam, simon.fraser, webkit-bug-importer, wenson_hsieh, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Mac   
OS: Unspecified   
Attachments:
Description Flags
Patch
sam: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews125 for ios-simulator-wk2 none

Description Daniel Bates 2018-07-03 15:21:24 PDT 
Remove support for the Strong Confirmation Password button as we never made use of it.
Comment 1 Radar WebKit Bug Importer 2018-07-03 15:27:48 PDT 
<rdar://problem/41795185>
Comment 2 Daniel Bates 2018-07-03 15:54:45 PDT 
Created attachment 344233 [details]
Patch
Comment 3 Sam Weinig 2018-07-03 17:05:47 PDT 
Comment on attachment 344233 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344233&action=review

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1096
>      AutoFillButtonType type = m_object->valueAutofillButtonType();
> -    return type == AutoFillButtonType::StrongConfirmationPassword || type == AutoFillButtonType::StrongPassword;
> +    return type == AutoFillButtonType::StrongPassword;

Temporary does not seem necessary.
Comment 4 EWS Watchlist 2018-07-03 17:38:56 PDT 
Comment on attachment 344233 [details]
Patch

Attachment 344233 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8430170

New failing tests:
accessibility/ios-simulator/strong-password-field.html
Comment 5 EWS Watchlist 2018-07-03 17:38:57 PDT 
Created attachment 344247 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 6 Daniel Bates 2018-07-06 09:17:05 PDT 
(In reply to Sam Weinig from comment #3)
> Comment on attachment 344233 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=344233&action=review
> 
> > Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:1096
> >      AutoFillButtonType type = m_object->valueAutofillButtonType();
> > -    return type == AutoFillButtonType::StrongConfirmationPassword || type == AutoFillButtonType::StrongPassword;
> > +    return type == AutoFillButtonType::StrongPassword;
> 
> Temporary does not seem necessary.

Will remove before landing.
Comment 7 Daniel Bates 2018-07-06 09:30:00 PDT 
Committed r233578: <https://trac.webkit.org/changeset/233578>
Comment 8 Ryan Haddad 2018-07-06 12:45:21 PDT 
(In reply to Build Bot from comment #4)
> Comment on attachment 344233 [details]
> Patch
> 
> Attachment 344233 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: https://webkit-queues.webkit.org/results/8430170
> 
> New failing tests:
> accessibility/ios-simulator/strong-password-field.html
Now that this change has landed, this test is failing on the bots:
https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Debug%20WK2%20(Tests)/r233581%20(5253)/results.html
Comment 9 Ryan Haddad 2018-07-06 14:50:38 PDT 
(In reply to Ryan Haddad from comment #8)
> (In reply to Build Bot from comment #4)
> > Comment on attachment 344233 [details]
> > Patch
> > 
> > Attachment 344233 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> > Output: https://webkit-queues.webkit.org/results/8430170
> > 
> > New failing tests:
> > accessibility/ios-simulator/strong-password-field.html
> Now that this change has landed, this test is failing on the bots:
> https://build.webkit.org/results/
> Apple%20iOS%2011%20Simulator%20Debug%20WK2%20(Tests)/r233581%20(5253)/
> results.html
I rebaslined the test in https://trac.webkit.org/r233595