| Summary: | Clean up the layer volatility code and logging | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, simon.fraser, thorton, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2018-07-02 19:48:57 PDT
Created attachment 344162 [details]
Patch
Attachment 344162 [details] did not pass style-queue:
ERROR: Source/WebKit/WebProcess/WebProcess.cpp:1443: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
ERROR: Source/WebKit/WebProcess/WebPage/WebPage.cpp:2252: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebPage/WebPage.h:672: Extra space before ( in function call [whitespace/parens] [4]
ERROR: Source/WebKit/WebProcess/WebPage/WebPage.h:1672: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 4 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 344162 [details] Patch Attachment 344162 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8421306 New failing tests: http/tests/security/canvas-remote-read-remote-video-redirect.html Created attachment 344168 [details]
Archive of layout-test-results from ews206 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
|