Bug 187282

Summary: Fix regression introduced in r233335
Product: WebKit Reporter: youenn fablet <youennf>
Component: Service WorkersAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Archive of layout-test-results from ews206 for win-future none

Description youenn fablet 2018-07-02 17:41:52 PDT
We should early return in case the load is navigate.
Comment 1 youenn fablet 2018-07-02 17:43:54 PDT
Created attachment 344158 [details]
Patch
Comment 2 Chris Dumez 2018-07-03 08:51:49 PDT
Comment on attachment 344158 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344158&action=review

> Source/WebKit/ChangeLog:10
> +

Please explain the fix in the changelog.
Comment 3 youenn fablet 2018-07-03 11:09:51 PDT
Created attachment 344198 [details]
Patch
Comment 4 EWS Watchlist 2018-07-03 13:07:26 PDT
Comment on attachment 344198 [details]
Patch

Attachment 344198 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8426712

New failing tests:
http/tests/security/canvas-remote-read-remote-video-localhost.html
http/tests/preload/onload_event.html
Comment 5 EWS Watchlist 2018-07-03 13:07:38 PDT
Created attachment 344207 [details]
Archive of layout-test-results from ews206 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews206  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 6 WebKit Commit Bot 2018-07-03 17:24:57 PDT
Comment on attachment 344198 [details]
Patch

Clearing flags on attachment: 344198

Committed r233491: <https://trac.webkit.org/changeset/233491>
Comment 7 WebKit Commit Bot 2018-07-03 17:24:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-07-03 17:26:13 PDT
<rdar://problem/41799926>