Bug 187277

Summary: Resource Load Statistics: Make WebsiteDataStore::getAllStorageAccessEntries() call the right network process instead of iterating over the process pools
Product: WebKit Reporter: John Wilander <wilander>
Component: WebKit Misc.Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description John Wilander 2018-07-02 15:59:48 PDT 
WebsiteDataStore::getAllStorageAccessEntries() needs to know which page is calling it and get the storage access entries from the associated network process.
Comment 1 Radar WebKit Bug Importer 2018-07-02 16:00:14 PDT 
<rdar://problem/41745510>
Comment 2 John Wilander 2018-07-02 16:15:49 PDT 
Created attachment 344143 [details]
Patch
Comment 3 Chris Dumez 2018-07-03 09:08:56 PDT 
Comment on attachment 344143 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344143&action=review

r=me

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:350
> +    if (webView) {

This should be an early return instead.

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:352
> +        if (webPageProxy) {

This should be an early return instead.

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:26
> +#import <WebKit/WKWebView.h>

Can this be forward-declared below like so?
@class WKWebView;

> Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:269
> +    if (auto* parentView = mainWebView()) {

Should be an early return.
Comment 4 John Wilander 2018-07-03 10:46:32 PDT 
Created attachment 344195 [details]
Patch for landing
Comment 5 John Wilander 2018-07-03 10:47:47 PDT 
Thanks, Chris! I took action on all your comments.
Comment 6 WebKit Commit Bot 2018-07-03 11:25:42 PDT 
Comment on attachment 344195 [details]
Patch for landing

Clearing flags on attachment: 344195

Committed r233468: <https://trac.webkit.org/changeset/233468>
Comment 7 WebKit Commit Bot 2018-07-03 11:25:44 PDT 
All reviewed patches have been landed.  Closing bug.