Bug 187241

Summary: [LFC] Implement preferred minimum width logic.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ews-watchlist, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews200 for win-future
none
Patch
none
Patch
none
Patch koivisto: review+

Description zalan 2018-07-01 21:48:44 PDT
and use it for shrink-to-fit.
Comment 1 zalan 2018-07-01 22:15:06 PDT
Created attachment 344074 [details]
Patch
Comment 2 EWS Watchlist 2018-07-01 23:56:55 PDT
Comment on attachment 344074 [details]
Patch

Attachment 344074 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8409408

New failing tests:
http/tests/security/video-poster-cross-origin-crash2.html
Comment 3 EWS Watchlist 2018-07-01 23:57:06 PDT
Created attachment 344080 [details]
Archive of layout-test-results from ews200 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews200  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 4 zalan 2018-07-02 07:56:34 PDT
Created attachment 344103 [details]
Patch
Comment 5 zalan 2018-07-02 16:46:01 PDT
Created attachment 344147 [details]
Patch
Comment 6 zalan 2018-07-03 07:46:37 PDT
Created attachment 344188 [details]
Patch
Comment 7 Antti Koivisto 2018-07-03 10:30:19 PDT
Comment on attachment 344188 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344188&action=review

> Source/WebCore/layout/FormattingContext.h:58
> +    struct MinimumMaximumIntrinsicWidth {

This is bit clunky. Maybe InstrinsicWidthConstraints or something?
Comment 8 zalan 2018-07-03 11:29:45 PDT
Committed r233469: <https://trac.webkit.org/changeset/233469>
Comment 9 Radar WebKit Bug Importer 2018-07-03 11:31:15 PDT
<rdar://problem/41784355>