Bug 187238

Summary: Clean up some spellchecking code
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: HTML EditingAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, commit-queue, ews-watchlist, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: DoNotImportToRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Attempt to bisect the WPE build failure
none
Try to fix WPE build
none
Archive of layout-test-results from ews204 for win-future none

Description Wenson Hsieh 2018-07-01 18:55:07 PDT
Followup to some of Darin's observations in https://bugs.webkit.org/show_bug.cgi?id=187225.
Comment 1 Wenson Hsieh 2018-07-01 19:11:30 PDT
Created attachment 344068 [details]
Patch
Comment 2 Wenson Hsieh 2018-07-01 19:44:27 PDT
Created attachment 344069 [details]
Attempt to bisect the WPE build failure
Comment 3 Wenson Hsieh 2018-07-01 21:35:57 PDT
Created attachment 344072 [details]
Try to fix WPE build
Comment 4 EWS Watchlist 2018-07-02 00:42:38 PDT
Comment on attachment 344072 [details]
Try to fix WPE build

Attachment 344072 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8409664

New failing tests:
http/tests/preload/onload_event.html
Comment 5 EWS Watchlist 2018-07-02 00:42:49 PDT
Created attachment 344082 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 6 WebKit Commit Bot 2018-07-02 13:57:00 PDT
Comment on attachment 344072 [details]
Try to fix WPE build

Clearing flags on attachment: 344072

Committed r233434: <https://trac.webkit.org/changeset/233434>
Comment 7 WebKit Commit Bot 2018-07-02 13:57:02 PDT
All reviewed patches have been landed.  Closing bug.