Bug 187229

Summary:

test-webkitpy never rebuilds lldbWebKitTester

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ddkilzer, ews-watchlist, glenn, lforschler, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Mac

OS:

macOS 10.13

See Also:

https://bugs.webkit.org/show_bug.cgi?id=187132

Attachments:

Description	Flags
Patch	ddkilzer: review+

Description Daniel Bates 2018-06-30 19:53:23 PDT

Currently once lldbWebKitTester is built for the active configuration (see script set-webkit-configuration) then it is never rebuilt by test-webkitpy regardless of whether the source for lldbWebKitTester has changed.

Comment 1 Daniel Bates 2018-06-30 19:59:16 PDT

Created attachment 344037 [details]
Patch

Comment 2 David Kilzer (:ddkilzer) 2018-06-30 21:39:33 PDT

Comment on attachment 344037 [details]
Patch

r=me

Comment 3 Daniel Bates 2018-06-30 23:00:43 PDT

Committed r233407: <https://trac.webkit.org/changeset/233407>

Comment 4 Radar WebKit Bug Importer 2018-06-30 23:01:24 PDT

<rdar://problem/41688400>

Comment 5 Simon Fraser (smfr) 2018-07-02 11:07:44 PDT

Thanks for the fix!