| Summary: | [CMake] build-webkit should be able to enable address sanitizer | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Michael Catanzaro <mcatanzaro> | ||||
| Component: | Tools / Tests | Assignee: | Michael Catanzaro <mcatanzaro> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bugs-noreply, calvaris, dbates, ews-watchlist, lforschler, mcatanzaro, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Attachments: |
|
||||||
|
Description
Michael Catanzaro
2018-06-30 11:58:02 PDT
Created attachment 344018 [details]
Patch
Comment on attachment 344018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344018&action=review Do we already support ASan building with CMake using script build-jsc? If not, we should fix this up. > Tools/ChangeLog:7 > + Please add a description for this change. I liked what you wrote in comment 0. Comment on attachment 344018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344018&action=review > Tools/Scripts/webkitdirs.pm:2255 > + determineASanIsEnabled(); It is unnecessary to call this. We should call asanIsEnabled() on the line below (notice it is a function call). (In reply to Daniel Bates from comment #2) > Comment on attachment 344018 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=344018&action=review > > Do we already support ASan building with CMake using script build-jsc? If > not, we should fix this up. We did not, but build-jsc uses buildCMakeProjectOrExit(), which calls generateBuildSystemFromCMakeProject(), which is the function I'm modifying here, so now it will. > > Tools/ChangeLog:7 > > + > > Please add a description for this change. I liked what you wrote in comment > 0. OK. (In reply to Daniel Bates from comment #3) > It is unnecessary to call this. We should call asanIsEnabled() on the line > below (notice it is a function call). Yes. Committed r233402: <https://trac.webkit.org/changeset/233402> |