| Summary: | Port WTF to OS(FUCHSIA) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, don.olmstead, fpizlo, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Adam Barth
2018-06-30 11:20:32 PDT
Created attachment 344017 [details]
Patch
Comment on attachment 344017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=344017&action=review r=me with nits. > Source/WTF/wtf/FastMalloc.cpp:366 > +#elif HAVE(RESOURCE_H) Can we have an implementation for Fuchsia? If we can implement it (but if it is a bit complicated for this patch), adding FIXME here is desirable. > Source/WTF/wtf/RandomDevice.cpp:33 > +#if !OS(DARWIN) && !OS(FUCHSIA) && OS(UNIX) We should have `OS(FUCHSIA)` guard in RandomDevice.h too not to have m_fd. > r=me with nits. Thanks! > > Source/WTF/wtf/FastMalloc.cpp:366 > > +#elif HAVE(RESOURCE_H) > > Can we have an implementation for Fuchsia? > If we can implement it (but if it is a bit complicated for this patch), > adding FIXME here is desirable. We removed resource.h from our libc in https://fuchsia.googlesource.com/zircon/+/67fec6dc8ea9285fb54f9bc741be63218439eda5%5E%21/ Apparently, the concepts expressed in that header don't map well to what we have planned in this area. For example, Fuchsia doesn't track resource limits at process level. Instead, resource usage is tracked at the job level to handle modern multiprocess applications. (A job is a container for processes and other jobs.) > > Source/WTF/wtf/RandomDevice.cpp:33 > > +#if !OS(DARWIN) && !OS(FUCHSIA) && OS(UNIX) > > We should have `OS(FUCHSIA)` guard in RandomDevice.h too not to have m_fd. Good idea. Created attachment 344020 [details]
Patch
Comment on attachment 344020 [details]
Patch
r=me
Comment on attachment 344020 [details] Patch Clearing flags on attachment: 344020 Committed r233401: <https://trac.webkit.org/changeset/233401> All reviewed patches have been landed. Closing bug. |