Bug 187216

Summary:

DeclarativeAnimation should suspend, resume, & stop m_eventQueue

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Animations

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dino, graouts, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	rniwa: review+

Description Ryosuke Niwa 2018-06-29 23:32:11 PDT

We need to stop/suspend GenericEventQueue when DeclarativeAnimation, as an active DOM object, gets stopped, suspended.
We should also resume it when we get out of the page cache, etc..

Comment 1 Radar WebKit Bug Importer 2018-06-30 00:02:49 PDT

<rdar://problem/41669739>

Comment 2 Antoine Quint 2018-07-19 17:21:13 PDT

DeclarativeAnimation is not an ActiveDOMObject… yet :)

Comment 3 Antoine Quint 2018-07-19 17:21:41 PDT

Except its superclass, WebAnimation, is. Duh.

Comment 4 Antoine Quint 2018-07-19 18:04:18 PDT

Created attachment 345412 [details]
Patch

Comment 5 Ryosuke Niwa 2018-07-19 19:24:44 PDT

Comment on attachment 345412 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=345412&action=review

> Source/WebCore/animation/DeclarativeAnimation.cpp:220
> +    ActiveDOMObject::suspend(reason);

There is no need to call this. It's empty.
But we should call WebAnimation::suspend(reason) to make this code future proof.

> Source/WebCore/animation/DeclarativeAnimation.cpp:226
> +    ActiveDOMObject::resume();

Ditto.

Comment 6 Antoine Quint 2018-07-20 10:08:49 PDT

Committed r234049: <https://trac.webkit.org/changeset/234049>