| Summary: | teach bisect-builds to fetch supported platforms from the rest api | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Lucas Forschler <lforschler> | ||||
| Component: | Tools / Tests | Assignee: | Lucas Forschler <lforschler> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, lforschler, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Safari 11 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Lucas Forschler
2018-06-29 14:43:28 PDT
Created attachment 343951 [details]
patch for review
Comment on attachment 343951 [details] patch for review View in context: https://bugs.webkit.org/attachment.cgi?id=343951&action=review > Tools/Scripts/bisect-builds:202 > + r = urllib2.urlopen(platform_url) You can consider making a separate method to fetching data from url, e.g.: fetch_data_from_url(url). That method can be used in fetch_revision_list() as well. But that can be done later on in a separate patch as well. > Tools/Scripts/bisect-builds:206 > + for platform in data['Items']: Is data guaranteed to have 'Items' key. what if data is empty? Do we want to crash here? You might consider using data.get('Items') Committed revision 233373. |