| Summary: | REGRESSION(r233362): check_flatpak() should not be verbose when flatpak environment has not been initialized | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bugs-noreply, calvaris, commit-queue, mcatanzaro, tsaunier | ||||
| Priority: | P2 | ||||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 186771 | ||||||
| Attachments: |
|
||||||
Created attachment 344011 [details]
Patch.
Comment on attachment 344011 [details] Patch. Clearing flags on attachment: 344011 Committed r233395: <https://trac.webkit.org/changeset/233395> All reviewed patches have been landed. Closing bug. |
It happens that when the flatpak environment has not been initialized, the scripts still try to run the flatpak binary in the function check_flatpak() in flatpakutils.py For example, If i just uninstall flatpak and I try to run I get $ Tools/Scripts/run-webkit-tests --gtk --release You need to install flatpak >= 0.10.0 to be able to use the 'Tools/Scripts/run-webkit-tests' script. You can find some informations about how to install it for your distribution at: * http://flatpak.org/ 20:15:13.186 21463 Using port 'gtk-wk2' [...] Or on the bots, just check the ouput generate-jsc-bundle from the release bot, the noise about flatpak there: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/13303/steps/generate-jsc-bundle/logs/stdio I think this should be avoided. The function check_flatpak() should avoid doing any check (or print any warning) if the flatpak environment has not been initialized