Bug 187119

Summary:

Fix a bug in $vm.callFrame() and apply previously requested renaming of $vm.println to print.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, fpizlo, keith_miller, msaboff, rmorisset, saam, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	none

Description Mark Lam 2018-06-27 15:18:54 PDT

I also renamed some other "print" functions to use "dump" instead to match their underlying C++ code that they will call e.g. CodeBlock::dumpSource().

Comment 1 Mark Lam 2018-06-27 15:22:24 PDT

Created attachment 343761 [details]
proposed patch.

Comment 2 Keith Miller 2018-06-27 15:33:26 PDT

Comment on attachment 343761 [details]
proposed patch.

r=me

Comment 3 Mark Lam 2018-06-27 15:34:04 PDT

Comment on attachment 343761 [details]
proposed patch.

Thanks for the review.  Landing now.

Comment 4 WebKit Commit Bot 2018-06-27 16:14:00 PDT

Comment on attachment 343761 [details]
proposed patch.

Clearing flags on attachment: 343761

Committed r233285: <https://trac.webkit.org/changeset/233285>

Comment 5 WebKit Commit Bot 2018-06-27 16:14:01 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Radar WebKit Bug Importer 2018-06-27 16:14:39 PDT

<rdar://problem/41550102>