| Summary: | Don't invoke post resolution callbacks when resolving computed style | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, cmarcelo, commit-queue, dbates, esprehn+autocc, ews-watchlist, ggaren, kangil.han, tsavell | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=187156 | ||||||||
| Attachments: |
|
||||||||
|
Description
Antti Koivisto
2018-06-27 12:49:44 PDT
Created attachment 343745 [details]
patch
Comment on attachment 343745 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=343745&action=review r=me > LayoutTests/ChangeLog:24 > +2018-06-15 Antti Koivisto <antti@apple.com> > + > + Semantic colors should not be transformed by color-filter > + https://bugs.webkit.org/show_bug.cgi?id=186566 > + <rdar://problem/40705739> > + > + Reviewed by NOBODY (OOPS!). > + > + * css3/color-filters/color-filter-ignore-semantic-expected.html: Added. > + * css3/color-filters/color-filter-ignore-semantic.html: Added. > + Revert please. Created attachment 343749 [details]
patch
Comment on attachment 343749 [details] patch Clearing flags on attachment: 343749 Committed r233281: <https://trac.webkit.org/changeset/233281> All reviewed patches have been landed. Closing bug. it looks like after revision 233281 we started getting consistent timeouts on tests. Tests Timeout: fast/dom/location-new-window-no-crash.html http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-window-open.html storage/indexeddb/modern/blob-cursor.html storage/indexeddb/modern/blob-svg-image.html failure report: https://build.webkit.org/results/Apple%20High%20Sierra%20Release%20WK2%20(Tests)/r233306%20(5312)/results.html |