Bug 187112

Summary: Add some more register state information when we crash in repatchPutById
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
mark.lam: review+
patch none

Description Saam Barati 2018-06-27 12:48:26 PDT 
...
Comment 1 Saam Barati 2018-06-27 15:08:13 PDT 
Created attachment 343756 [details]
patch
Comment 2 Mark Lam 2018-06-27 15:14:10 PDT 
Comment on attachment 343756 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343756&action=review

r=me

> Source/JavaScriptCore/jit/Repatch.cpp:590
> +                        if (offset != conditionSetOffset) {

Add UNLIKELY() around the condition?
Comment 3 Saam Barati 2018-06-27 16:04:36 PDT 
Created attachment 343764 [details]
patch
Comment 4 WebKit Commit Bot 2018-06-27 17:18:57 PDT 
Comment on attachment 343764 [details]
patch

Clearing flags on attachment: 343764

Committed r233291: <https://trac.webkit.org/changeset/233291>
Comment 5 WebKit Commit Bot 2018-06-27 17:18:59 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-06-27 17:19:26 PDT 
<rdar://problem/41553229>