Bug 187103

Summary: Layout Test js/error-should-not-strong-reference-global-object.html is a flaky failure
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: NEW ---    
Severity: Normal CC: ap, keith_miller, mark.lam, realdawei, tsavell
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=186372
Attachments:
Description Flags
Patch
none
Mark test as flaky none

Description Ryan Haddad 2018-06-27 10:15:18 PDT
The following layout test is flaky on macOS

js/error-should-not-strong-reference-global-object.html

Probable cause:

Unknown, this test was flaky when landed, a fix was landed, now the text diff has changed.

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Ferror-should-not-strong-reference-global-object.html

--- /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/js/error-should-not-strong-reference-global-object-expected.txt
+++ /Volumes/Data/slave/highsierra-release-tests-wk1/build/layout-test-results/js/error-should-not-strong-reference-global-object-actual.txt
@@ -1,4 +1,5 @@
-PASS successfullyParsed is true
+CONSOLE MESSAGE: line 48: Error: There are more global objects than there should be: actual count = 2654
+FAIL successfullyParsed should be true (of type boolean). Was undefined (of type undefined).
 
 TEST COMPLETE
Comment 1 Ryan Haddad 2018-06-27 10:16:24 PDT
This test is also frequently timing out on Sierra Debug WK2.
Comment 2 Truitt Savell 2018-06-29 13:22:31 PDT
Created attachment 343936 [details]
Patch
Comment 3 Truitt Savell 2018-06-29 13:41:54 PDT
Created attachment 343940 [details]
Mark test as flaky
Comment 4 Ryan Haddad 2018-06-29 13:47:52 PDT
Comment on attachment 343940 [details]
Mark test as flaky

Clearing flags on attachment: 343940

Committed r233369: <https://trac.webkit.org/changeset/233369>
Comment 5 Ryan Haddad 2019-07-25 14:39:40 PDT
This test is also a flaky failure on iOS Simulator Debug:
--- /Volumes/Data/slave/ios-simulator-12-debug-tests-wk2/build/layout-test-results/js/error-should-not-strong-reference-global-object-expected.txt
+++ /Volumes/Data/slave/ios-simulator-12-debug-tests-wk2/build/layout-test-results/js/error-should-not-strong-reference-global-object-actual.txt
@@ -1,4 +1,5 @@
-PASS successfullyParsed is true
+CONSOLE MESSAGE: line 48: Error: There are more global objects than there should be: actual count = 51
+FAIL successfullyParsed should be true (of type boolean). Was undefined (of type undefined).
 
 TEST COMPLETE