Bug 187099

Summary: REGRESSION(r233208): Completion handler does not get called on GTK port
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, bfulgham, commit-queue, fred.wang, ggaren, koivisto, mcatanzaro, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 186903    
Attachments:
Description Flags
Patch none

Description Chris Dumez 2018-06-27 08:56:12 PDT 
Regression(r233208): Completion handler does not get called on GTK port:
Thread 1 (Thread 0x7fac3d9906c0 (LWP 38186)):
#0  0x00005630fe15d3c8 in WTFCrash () at /home/slave/webkitgtk/gtk-linux-64-debug/build/Source/WTF/wtf/Assertions.cpp:267
#1  0x00007fac55a42fc0 in WTF::CompletionHandler<void()>::~CompletionHandler(void) (this=0x7fff1fef7d08, __in_chrg=<optimized out>) at DerivedSources/ForwardingHeaders/wtf/CompletionHandler.h:51
#2  0x00007fac56355de4 in (anonymous namespace)::WebResourceLoadStatisticsStore::<lambda()>::operator()(void) (__closure=0x7fac3d0d3060) at ../../Source/WebKit/UIProcess/WebResourceLoadStatisticsStore.cpp:1360
#3  0x00007fac563824aa in WTF::Function<void()>::CallableWrapper<WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains(const WTF::Vector<WTF::String>&, const WTF::Vector<WTF::String>&, const WTF::Vector<WTF::String>&, WebKit::ShouldClearFirst, WTF::CompletionHandler<void()>&&)::<lambda()> >::call(void) (this=0x7fac3d0d3058) at DerivedSources/ForwardingHeaders/wtf/Function.h:101
#4  0x00005630fe17ca8a in WTF::Function<void()>::operator()(void) const (this=0x7fff1fef7d98) at ../../Source/WTF/wtf/Function.h:56
#5  0x00005630fe1908b5 in WTF::RunLoop::performWork (this=0x7fac3d0f7000) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Source/WTF/wtf/RunLoop.cpp:123
#6  0x00005630fe1de684 in WTF::RunLoop::<lambda(gpointer)>::operator()(gpointer) const (__closure=0x0, userData=0x7fac3d0f7000) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Source/WTF/wtf/glib/RunLoopGLib.cpp:68
#7  0x00005630fe1de6a8 in WTF::RunLoop::<lambda(gpointer)>::_FUN(gpointer) () at /home/slave/webkitgtk/gtk-linux-64-debug/build/Source/WTF/wtf/glib/RunLoopGLib.cpp:70
#8  0x00005630fe1de624 in WTF::<lambda(GSource*, GSourceFunc, gpointer)>::operator()(GSource *, GSourceFunc, gpointer) const (__closure=0x0, source=0x5630fe5d9110, callback=0x5630fe1de68b <WTF::RunLoop::<lambda(gpointer)>::_FUN(gpointer)>, userData=0x7fac3d0f7000) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Source/WTF/wtf/glib/RunLoopGLib.cpp:45
#9  0x00005630fe1de653 in WTF::<lambda(GSource*, GSourceFunc, gpointer)>::_FUN(GSource *, GSourceFunc, gpointer) () at /home/slave/webkitgtk/gtk-linux-64-debug/build/Source/WTF/wtf/glib/RunLoopGLib.cpp:46
#10 0x00007fac4ca4f81a in g_main_dispatch () at /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3148
#11 g_main_context_dispatch () at /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3813
#12 0x00007fac4ca4fba8 in g_main_context_iterate () at /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:3886
#13 0x00007fac4ca4fec2 in g_main_loop_run () at /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Source/glib-2.54.2/glib/gmain.c:4082
#14 0x00005630fe1deb61 in WTF::RunLoop::run () at /home/slave/webkitgtk/gtk-linux-64-debug/build/Source/WTF/wtf/glib/RunLoopGLib.cpp:96
#15 0x00005630fe15c38c in WTR::TestController::platformRunUntil (this=0x7fff1fef8c70, timeout=7.5) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp:88
#16 0x00005630fe11fb3b in WTR::TestController::runUntil (this=0x7fff1fef8c70, done=@0x7fff1fef8d6c: false, timeout=7.5) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/WebKitTestRunner/TestController.cpp:1322
#17 0x00005630fe11dd44 in WTR::TestController::resetStateToConsistentValues (this=0x7fff1fef8c70, options=...) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/WebKitTestRunner/TestController.cpp:909
#18 0x00005630fe11cce4 in WTR::TestController::ensureViewSupportsOptionsForTest (this=0x7fff1fef8c70, test=...) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/WebKitTestRunner/TestController.cpp:672
#19 0x00005630fe11f083 in WTR::TestController::configureViewForTest (this=0x7fff1fef8c70, test=...) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/WebKitTestRunner/TestController.cpp:1174
#20 0x00005630fe13639a in WTR::TestInvocation::invoke (this=0x5630feb67ca0) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/WebKitTestRunner/TestInvocation.cpp:152
#21 0x00005630fe11f96b in WTR::TestController::runTest (this=0x7fff1fef8c70, inputLine=0x7fff1fef83e0 "/home/slave/webkitgtk/gtk-linux-64-debug-tests/build/LayoutTests/accessibility/accessibility-crash-setattribute.html'--timeout'30000") at /home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/WebKitTestRunner/TestController.cpp:1283
#22 0x00005630fe11fa4e in WTR::TestController::runTestingServerLoop (this=0x7fff1fef8c70) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/WebKitTestRunner/TestController.cpp:1300
#23 0x00005630fe11fa82 in WTR::TestController::run (this=0x7fff1fef8c70) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/WebKitTestRunner/TestController.cpp:1308
#24 0x00005630fe11adfd in WTR::TestController::TestController (this=0x7fff1fef8c70, argc=2, argv=0x7fff1fef8f48) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/WebKitTestRunner/TestController.cpp:130
#25 0x00005630fe15cd29 in main (argc=2, argv=0x7fff1fef8f48) at /home/slave/webkitgtk/gtk-linux-64-debug/build/Tools/WebKitTestRunner/gtk/main.cpp:46
Comment 1 Chris Dumez 2018-06-27 08:57:47 PDT 
Created attachment 343714 [details]
Patch
Comment 2 WebKit Commit Bot 2018-06-27 09:36:49 PDT 
Comment on attachment 343714 [details]
Patch

Clearing flags on attachment: 343714

Committed r233261: <https://trac.webkit.org/changeset/233261>
Comment 3 WebKit Commit Bot 2018-06-27 09:36:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-06-27 09:39:28 PDT 
<rdar://problem/41527898>
Comment 5 Frédéric Wang (:fredw) 2018-06-28 06:25:56 PDT 
@Chris: Thanks, that solved the issue indeed!