Bug 187078

Summary:

[GTK][WPE] Remove gflags from libwebrtc build

Product:

WebKit

Reporter:

Yusuke Suzuki <ysuzuki>

Component:

New Bugs

Assignee:

Yusuke Suzuki <ysuzuki>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alex, cgarcia, mcatanzaro, webkit-bug-importer, zan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	alex: review+

Description Yusuke Suzuki 2018-06-26 19:34:17 PDT

[GTK][WPE] Remove gflags from libwebrtc build

Comment 1 Yusuke Suzuki 2018-06-26 19:37:07 PDT

Created attachment 343679 [details]
Patch

Comment 2 Alejandro G. Castro 2018-06-27 01:02:59 PDT

Comment on attachment 343679 [details]
Patch

LGTM, if bots are happy it is great we can avoid that.

Comment 3 Yusuke Suzuki 2018-06-27 01:17:43 PDT

Thanks!

mac and ios bots are unrelated since they do not use CMake. They failed with transient errors (connection to git.webkit.org is timing out).
gtk-wk2 becomes green. So, I think it is OK.

Comment 4 Yusuke Suzuki 2018-06-27 01:19:10 PDT

Committed r233249: <https://trac.webkit.org/changeset/233249>

Comment 5 Radar WebKit Bug Importer 2018-06-27 01:20:45 PDT

<rdar://problem/41512519>