Bug 187076

Summary: AX: [iOS] Remove the ability to set keyboard focus when VoiceOver takes focus
Product: WebKit Reporter: Nan Wang <n_wang>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, ews-watchlist, jcraig, jdiggs, n_wang, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
patch
none
patch
none
patch none

Description Nan Wang 2018-06-26 18:16:14 PDT
There's no documentation on iOS saying that we should do this. And this would allow people to track VoiceOver usage on iOS.

<rdar://problem/41190221>
Comment 1 Nan Wang 2018-06-26 18:38:01 PDT
Created attachment 343670 [details]
patch
Comment 2 Nan Wang 2018-06-26 18:40:00 PDT
Created attachment 343671 [details]
patch

added changelog
Comment 3 Nan Wang 2018-06-26 18:43:23 PDT
Created attachment 343673 [details]
patch
Comment 4 chris fleizach 2018-06-26 21:38:07 PDT
Comment on attachment 343673 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343673&action=review

> Source/WebCore/ChangeLog:9
> +        it would allow web authors to track AT usage.

We should probably state here that instead of the tracking thing thisbsi causing website incompatibility issues by causing focus to be lost

> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:-2064
> -        return;

Is there an aom event that we do want to send here?
Comment 5 Nan Wang 2018-06-26 23:05:55 PDT
Comment on attachment 343673 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343673&action=review

>> Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:-2064
>> -        return;
> 
> Is there an aom event that we do want to send here?

I was thinking to add that in another patch. But I can do it here.
Comment 6 Nan Wang 2018-06-26 23:08:36 PDT
Created attachment 343692 [details]
patch

update
Comment 7 WebKit Commit Bot 2018-06-27 09:10:28 PDT
Comment on attachment 343692 [details]
patch

Clearing flags on attachment: 343692

Committed r233257: <https://trac.webkit.org/changeset/233257>
Comment 8 WebKit Commit Bot 2018-06-27 09:10:30 PDT
All reviewed patches have been landed.  Closing bug.