Bug 187074

Summary:

eval() is wrong about the LiteralParser never throwing any exceptions.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, keith_miller, msaboff, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	none

Description Mark Lam 2018-06-26 17:49:57 PDT

The LiteralParser may have thrown a StackOverflowError or OutOfMemoryError too.

<rdar://problem/41461099>

Comment 1 Mark Lam 2018-06-26 17:59:32 PDT

Created attachment 343667 [details]
proposed patch.

Comment 2 Saam Barati 2018-06-26 18:11:52 PDT

r=me

Comment 3 Mark Lam 2018-06-26 19:42:32 PDT

Comment on attachment 343667 [details]
proposed patch.

Thanks for the review. Landing now.

Comment 4 WebKit Commit Bot 2018-06-26 20:10:23 PDT

Comment on attachment 343667 [details]
proposed patch.

Clearing flags on attachment: 343667

Committed r233242: <https://trac.webkit.org/changeset/233242>

Comment 5 WebKit Commit Bot 2018-06-26 20:10:25 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Radar WebKit Bug Importer 2018-06-26 20:13:58 PDT

<rdar://problem/41504820>

Comment 7 Mark Lam 2018-06-26 20:47:58 PDT

<rdar://problem/41461099>