Bug 187067

Summary: Add a sandbox profile for com.google.o1dbrowserplugin plugin
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description youenn fablet 2018-06-26 15:56:31 PDT
Add a sandbox profile for com.google.o1dbrowserplugin plugin
Comment 1 youenn fablet 2018-06-26 15:58:33 PDT
Created attachment 343652 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2018-06-26 15:58:58 PDT
<rdar://problem/41495903>
Comment 3 Brent Fulgham 2018-06-26 16:50:51 PDT
Comment on attachment 343652 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343652&action=review

r=me

> Source/WebKit/Resources/PlugInSandboxProfiles/com.google.o1dbrowserplugin.sb:34
> +    (prefix "/private/tmp"))

It would be better if this could be limited to some set of things Google Talk uses. But perhaps they don't use a subdirectory for their files.
Comment 4 youenn fablet 2018-06-26 16:55:14 PDT
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 343652 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=343652&action=review
> 
> r=me
> 
> > Source/WebKit/Resources/PlugInSandboxProfiles/com.google.o1dbrowserplugin.sb:34
> > +    (prefix "/private/tmp"))
> 
> It would be better if this could be limited to some set of things Google
> Talk uses. But perhaps they don't use a subdirectory for their files.

Right now, it seems the folder is generated randomly.
Maybe we can ask for some changes though.
Comment 5 WebKit Commit Bot 2018-06-26 17:22:08 PDT
Comment on attachment 343652 [details]
Patch

Clearing flags on attachment: 343652

Committed r233230: <https://trac.webkit.org/changeset/233230>
Comment 6 WebKit Commit Bot 2018-06-26 17:22:09 PDT
All reviewed patches have been landed.  Closing bug.