| Summary: | Promote some experimental features to traditional features | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, dino, mcatanzaro, mjs, rniwa, simon.fraser, webkit-bug-importer, wenson_hsieh, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Tim Horton
2018-06-26 08:37:15 PDT
Created attachment 343604 [details]
Patch
Comment on attachment 343604 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343604&action=review > Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:127 > - RuntimeEnabledFeatures::sharedFeatures().setCacheAPIEnabled(store.getBoolValueForKey(WebPreferencesKey::cacheAPIEnabledKey())); > + RuntimeEnabledFeatures::sharedFeatures().setCacheAPIEnabled(store.getBoolValueForKey(WebPreferencesKey::serviceWorkersEnabledKey())); I'm not sure I like this, but I agree that it makes sense to tie these settings together... and we probably don't want to get into the rabbit hole of having runtime options depend on each other, like we do for build options. (In reply to Michael Catanzaro from comment #2) > Comment on attachment 343604 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=343604&action=review > > > Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.cpp:127 > > - RuntimeEnabledFeatures::sharedFeatures().setCacheAPIEnabled(store.getBoolValueForKey(WebPreferencesKey::cacheAPIEnabledKey())); > > + RuntimeEnabledFeatures::sharedFeatures().setCacheAPIEnabled(store.getBoolValueForKey(WebPreferencesKey::serviceWorkersEnabledKey())); > > I'm not sure I like this, but I agree that it makes sense to tie these > settings together... and we probably don't want to get into the rabbit hole > of having runtime options depend on each other, like we do for build options. This plan came from some of the SW people, so I Cc’d them so they could comment. Ahh, it doesn’t work because it doesn’t turn on the WebCore RuntimeEnabledFeature. Created attachment 343609 [details]
Patch
Comment on attachment 343609 [details] Patch Rejecting attachment 343609 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 343609, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit contributors.json is malformed: Expecting property name enclosed in double quotes: line 166 column 4 (char 3586) Full output: https://webkit-queues.webkit.org/results/8349424 (In reply to WebKit Commit Bot from comment #6) > contributors.json is malformed: Expecting property name enclosed in double > quotes: line 166 column 4 (char 3586) Tim, I think it's complaining about the trailing comma that you added in r233209... try removing that comma. Created attachment 343627 [details]
patch for cq
Comment on attachment 343627 [details] patch for cq Clearing flags on attachment: 343627 Committed r233215: <https://trac.webkit.org/changeset/233215> All reviewed patches have been landed. Closing bug. |