| Summary: | [GCrypt] Move definitions of GCryptUtilities helpers into a separate source file | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ews-watchlist, jiewen_tan, mcatanzaro, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Zan Dobersek
2018-06-25 23:20:14 PDT
Created attachment 343587 [details]
Patch
Comment on attachment 343587 [details]
Patch
r=me since this is clearly an improvement.
I'm not thrilled about have a bunch of free functions inside the WebCore namespace, outside any class or other namespace. It would be nice if these functions were inside some additional namespace.
Comment on attachment 343587 [details] Patch Attachment 343587 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8348613 New failing tests: http/tests/preload/onload_event.html Created attachment 343624 [details]
Archive of layout-test-results from ews202 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 343587 [details] Patch Clearing flags on attachment: 343587 Committed r233247: <https://trac.webkit.org/changeset/233247> All reviewed patches have been landed. Closing bug. |