Bug 187023

Summary:

[ews-build] Add support for WebKitPerl-Tests-EWS

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, ews-watchlist, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=187014
https://bugs.webkit.org/show_bug.cgi?id=187148

Attachments:

Description	Flags
Proposed patch	lforschler: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews202 for win-future	none

Aakash Jain

Reported 2018-06-25 16:35:35 PDT

We should add support for Webkitperl-tests-EWS.

Attachments
Proposed patch (4.33 KB, patch) 2018-06-25 16:38 PDT, Aakash Jain	lforschler: review+ ews-watchlist: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews202 for win-future (12.87 MB, application/zip) 2018-06-26 04:46 PDT, EWS Watchlist	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Aakash Jain

Comment 1 2018-06-25 16:38:28 PDT

Created attachment 343556 [details] Proposed patch

EWS Watchlist

Comment 2 2018-06-25 16:40:38 PDT Comment hidden (obsolete)

Attachment 343556 [details] did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:279: [TestRunWebkitperlTests.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:279: [TestRunWebkitperlTests.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:294: [TestRunWebkitperlTests.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:294: [TestRunWebkitperlTests.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 4 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

EWS Watchlist

Comment 3 2018-06-26 04:46:28 PDT Comment hidden (obsolete)

Comment on attachment 343556 [details] Proposed patch Attachment 343556 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8345602 New failing tests: http/tests/security/contentSecurityPolicy/userAgentShadowDOM/allow-audio.html

EWS Watchlist

Comment 4 2018-06-26 04:46:39 PDT Comment hidden (obsolete)

Created attachment 343599 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Lucas Forschler

Comment 5 2018-06-26 16:43:51 PDT

Comment on attachment 343556 [details] Proposed patch This patch seems fine, except for casing. It looks like we are using all kinds of different styles here: WebkitpyFactory I think should be WebKitPyFactory or WebKitpyFactory TestRunWebkitperlTests -> TestRunWebKitPerlTests name": "Webkitperl-tests-EWS" -> WebKitPerl-Tests-EWS etc... can we standardize on using CamelCase, and making sure we capitalize the K in WebKit ? if this means refactoring the entire config, please do it in a separate patch that includes the refactor globally.

Aakash Jain

Comment 6 2018-06-26 17:16:38 PDT

> etc... can we standardize on using CamelCase, and making sure we capitalize > the K in WebKit ? > if this means refactoring the entire config, please do it in a separate > patch that includes the refactor globally. Sure, will do that.

Aakash Jain

Comment 7 2018-06-26 17:17:51 PDT

Committed r233229: <https://trac.webkit.org/changeset/233229>.

Radar WebKit Bug Importer

Comment 8 2018-06-26 17:19:12 PDT

<rdar://problem/41499402>

Note You need to log in before you can comment on or make changes to this bug.