| Summary: | [ews-build] Add support for compiling WebKit | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, ap, ews-watchlist, lforschler, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Aakash Jain
2018-06-25 15:01:01 PDT
Created attachment 343549 [details] Proposed patch This is similar to what we use in other Buildbot code (in build.webkit.org) Also tested on ews-build.webkit-uat.org (http://ews-build.webkit-uat.org/#/builders/9/builds/9) Attachment 343549 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:272: [TestKillOldProcesses.test_success] Undefined variable 'KillOldProcesses' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:280: [TestKillOldProcesses.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:280: [TestKillOldProcesses.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:284: [TestKillOldProcesses.test_failure] Undefined variable 'KillOldProcesses' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:293: [TestKillOldProcesses.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:293: [TestKillOldProcesses.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:306: [TestCleanBuild.test_success] Undefined variable 'CleanBuild' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:315: [TestCleanBuild.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:315: [TestCleanBuild.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:319: [TestCleanBuild.test_failure] Undefined variable 'CleanBuild' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:329: [TestCleanBuild.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:329: [TestCleanBuild.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:342: [TestCompileWebKit.test_success] Undefined variable 'CompileWebKit' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:351: [TestCompileWebKit.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:351: [TestCompileWebKit.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:355: [TestCompileWebKit.test_failure] Undefined variable 'CompileWebKit' [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:365: [TestCompileWebKit.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:365: [TestCompileWebKit.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:99: trailing whitespace [pep8/W291] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:140: [KillOldProcesses.__init__] Use of super on an old style class [pylint/E1002] [5]
Total errors found: 20 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 343549 [details] Proposed patch Attachment 343549 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8340565 New failing tests: http/tests/security/canvas-remote-read-remote-video-localhost.html Created attachment 343571 [details]
Archive of layout-test-results from ews202 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 343549 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=343549&action=review > Tools/BuildSlaveSupport/ews-build/config.json:246 > + "architectures": ["i386"], are we not using x86_64 on windows for this configuration? > Tools/BuildSlaveSupport/ews-build/steps.py:86 > + if platform not in ('gtk', 'wincairo', 'ios', 'jsc-only', 'wpe'): it would be nice if we had a "supported platforms" list somewhere we could use... rather than having to manually update them here. Comment on attachment 343549 [details] Proposed patch > are we not using x86_64 on windows for this configuration? Removed windows changes from the patch for now, will add windows configuration in a separate patch. > it would be nice if we had a "supported platforms" list somewhere we could use... rather than having to manually update them here. Added FIXME as discussed. Committed r233235: <https://trac.webkit.org/changeset/233235>. |