| Summary: | Simplify NetworkStorageSession::getAllStorageAccessEntries() | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | beidson, bfulgham, commit-queue, ews-watchlist, ggaren, webkit-bug-importer, wilander, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Chris Dumez
2018-06-25 14:18:15 PDT
Created attachment 343537 [details]
Patch
This code is test infrastructure afaik. Tests under http/tests/storageAccess/ should ensure its functionality is maintained with this change. (In reply to John Wilander from comment #2) > This code is test infrastructure afaik. Tests under > http/tests/storageAccess/ should ensure its functionality is maintained with > this change. I verified locally that these tests still pass with my change. Comment on attachment 343537 [details] Patch Attachment 343537 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8341339 New failing tests: http/tests/security/canvas-remote-read-remote-video-redirect.html Created attachment 343578 [details]
Archive of layout-test-results from ews202 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 343537 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343537&action=review > Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:335 > + for (auto& innerPair : pair.value) Why not using HashMap::values on both for loops? Created attachment 343635 [details]
Patch
(In reply to youenn fablet from comment #6) > Comment on attachment 343537 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=343537&action=review > > > Source/WebCore/platform/network/cf/NetworkStorageSessionCFNet.cpp:335 > > + for (auto& innerPair : pair.value) > > Why not using HashMap::values on both for loops? Good point :D Comment on attachment 343635 [details] Patch Clearing flags on attachment: 343635 Committed r233222: <https://trac.webkit.org/changeset/233222> All reviewed patches have been landed. Closing bug. |