| Summary: | [ews-build] Add support for Bindings-tests-EWS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aakash_jain, ap, ews-watchlist, lforschler, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | Other | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=187023 https://bugs.webkit.org/show_bug.cgi?id=187330 |
||||||
| Attachments: |
|
||||||
|
Description
Aakash Jain
2018-06-25 13:52:24 PDT
Created attachment 343535 [details]
Proposed patch
Attachment 343535 [details] did not pass style-queue:
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:247: [TestRunBindingsTests.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:247: [TestRunBindingsTests.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:259: [TestRunBindingsTests.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:259: [TestRunBindingsTests.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5]
Total errors found: 4 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
This is similar to what we use in other Buildbot code. Also tested on ews-build.webkit-uat.org (http://ews-build.webkit-uat.org/#/builders/14/builds/5) style-queue warnings are false positive. Committed r233175: <https://trac.webkit.org/changeset/233175> |