| Summary: | [iPad apps on macOS] Web process crashes when attempting to play embedded YouTube video in News | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||
| Component: | Media | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bdakin, commit-queue, eric.carlson, ews-watchlist, thorton, timothy, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Wenson Hsieh
2018-06-25 13:02:10 PDT
Created attachment 343529 [details]
Patch
Comment on attachment 343529 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343529&action=review > Source/WebCore/platform/RemoteCommandListener.cpp:31 > +#if (!PLATFORM(IOS) && !PLATFORM(MAC)) || ENABLE(MINIMAL_SIMULATOR) In the ideal world this would become something like HAS(MEDIAREMOTE) (In reply to Tim Horton from comment #2) > Comment on attachment 343529 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=343529&action=review > > > Source/WebCore/platform/RemoteCommandListener.cpp:31 > > +#if (!PLATFORM(IOS) && !PLATFORM(MAC)) || ENABLE(MINIMAL_SIMULATOR) > > In the ideal world this would become something like HAS(MEDIAREMOTE) Good point. It looks like HAVE(MEDIA_PLAYER) already exists, and it's closer to what I should be switching on for this bug. I'll change this to use that instead. Created attachment 343544 [details]
Patch for landing
Comment on attachment 343529 [details] Patch Attachment 343529 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8337342 New failing tests: http/tests/preload/onload_event.html Created attachment 343548 [details]
Archive of layout-test-results from ews204 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 343544 [details] Patch for landing Clearing flags on attachment: 343544 Committed r233182: <https://trac.webkit.org/changeset/233182> |