| Summary: | Web Inspector: Dark Mode: color outline is too dark | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||||
| Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bburg, commit-queue, inspector-bugzilla-changes, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 343453 [details]
Patch
Created attachment 343454 [details]
[Screenshot] With patch applied
Comment on attachment 343453 [details]
Patch
Shouldn't this be using the focus ring color? I am not a fan of that gray outline if a caret selection will always look different from it.
(In reply to Brian Burg from comment #3) > Comment on attachment 343453 [details] > Patch > > Shouldn't this be using the focus ring color? I am not a fan of that gray > outline if a caret selection will always look different from it. This outline is only visible when hovering (with a mouse cursor). The focus ring may be shown elsewhere. Comment on attachment 343453 [details]
Patch
r=me
Comment on attachment 343453 [details] Patch Clearing flags on attachment: 343453 Committed r233156: <https://trac.webkit.org/changeset/233156> All reviewed patches have been landed. Closing bug. |
Created attachment 343452 [details] [Screenshot] Bug When hovering a color declaration in CSS, e.g. #000, the outline is so dark that it's hardly visible.