Bug 186973

Summary: [Cocoa] Improve ARC compatibility of more code in JavaScriptCore
Product: WebKit Reporter: Darin Adler <darin>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, cdumez, cmarcelo, dbates, ews-watchlist, joepeck, keith_miller, mark.lam, mitz, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=201803
Bug Depends on:    
Bug Blocks: 221107    
Attachments:
Description Flags
Patch
mitz: review+
Patch
none
Patch none

Description Darin Adler 2018-06-23 09:11:28 PDT 
[Cocoa] Improve ARC compatibility of more code in JavaScriptCore
Comment 1 Darin Adler 2018-06-23 09:56:52 PDT 
Created attachment 343440 [details]
Patch
Comment 2 Darin Adler 2018-06-29 17:09:34 PDT Comment hidden (obsolete)
Comment 3 Darin Adler 2018-06-30 17:46:02 PDT 
Created attachment 344027 [details]
Patch
Comment 4 Darin Adler 2018-07-01 11:23:59 PDT 
Committed r233409: <https://trac.webkit.org/changeset/233409>
Comment 5 Radar WebKit Bug Importer 2018-07-01 11:24:48 PDT 
<rdar://problem/41699383>
Comment 6 Keith Miller 2018-07-01 11:49:16 PDT 
Comment on attachment 344027 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344027&action=review

> Source/JavaScriptCore/API/JSContextInternal.h:33
> -    CallbackData *next;
> +    CallbackData* next;

I thought in Objective-C++ code we followed the Objective-C style of putting the * next to the variable name rather than our C++ style?
Comment 7 mitz 2018-07-01 12:14:37 PDT 
(In reply to Keith Miller from comment #6)
> Comment on attachment 344027 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=344027&action=review
> 
> > Source/JavaScriptCore/API/JSContextInternal.h:33
> > -    CallbackData *next;
> > +    CallbackData* next;
> 
> I thought in Objective-C++ code we followed the Objective-C style of putting
> the * next to the variable name rather than our C++ style?

* placement depends on the type. For Objective-C classes, the * comes after the space.
Comment 8 Darin Adler 2019-09-15 10:47:02 PDT 
Comment on attachment 344027 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=344027&action=review

> Source/JavaScriptCore/API/JSVirtualMachine.mm:-190
> -        [ownedObjects release];

This change should not have been included in the patch, and was a mismerge. It introduced a storage leak fixed in bug 201803.