Bug 186955

Summary:

[ews-build] Add support for Style-EWS

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, ews-watchlist, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	lforschler: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews204 for win-future	none

Description Aakash Jain 2018-06-22 17:59:38 PDT

We should add build steps for Style-EWS.

Comment 1 Aakash Jain 2018-06-22 18:45:59 PDT

Created attachment 343413 [details]
Proposed patch

This is similar to what we use in other Buildbot code for pre-commit testing.

Also tested on ews-build.webkit-uat.org (http://ews-build.webkit-uat.org/#/builders/5/builds/5)

Comment 2 EWS Watchlist 2018-06-22 18:48:15 PDT Comment hidden (obsolete)

Attachment 343413 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:30:  No name 'internet' in module 'twisted'  [pylint/E0611] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:31:  No name 'python' in module 'twisted'  [pylint/E0611] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:32:  No name 'trial' in module 'twisted'  [pylint/E0611] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:39:  [BuildStepMixinAdditions.setUpBuildStep] Instance of 'BuildStepMixinAdditions' has no 'patch' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:94:  [BuildStepMixinAdditions._checkSpawnProcess] Instance of 'BuildStepMixinAdditions' has no 'fail' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:97:  [BuildStepMixinAdditions._checkSpawnProcess] Instance of 'BuildStepMixinAdditions' has no 'assertEqual' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:124:  [BuildStepMixinAdditions.runStep.check] Instance of 'BuildStepMixinAdditions' has no 'assertEqual' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:126:  [BuildStepMixinAdditions.runStep.check] Instance of 'BuildStepMixinAdditions' has no 'assertEqual' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:129:  [BuildStepMixinAdditions.runStep.check] Instance of 'FakeBuild' has no 'sources' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:131:  [BuildStepMixinAdditions.runStep.check] Instance of 'BuildStepMixinAdditions' has no 'assertEqual' member  [pylint/E1101] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:146:  [TestCheckStyle.test_success_internal] Undefined variable 'CheckStyle'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:157:  [TestCheckStyle.test_success_internal] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:157:  [TestCheckStyle.test_success_internal] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:157:  [TestCheckStyle.test_success_internal] Undefined variable 'SUCCESS'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:161:  [TestCheckStyle.test_failure_unknown_try_codebase] Undefined variable 'CheckStyle'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:172:  [TestCheckStyle.test_failure_unknown_try_codebase] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:172:  [TestCheckStyle.test_failure_unknown_try_codebase] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:172:  [TestCheckStyle.test_failure_unknown_try_codebase] Undefined variable 'FAILURE'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:176:  [TestCheckStyle.test_failures_with_style_issues] Undefined variable 'CheckStyle'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:194:  [TestCheckStyle.test_failures_with_style_issues] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:194:  [TestCheckStyle.test_failures_with_style_issues] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:194:  [TestCheckStyle.test_failures_with_style_issues] Undefined variable 'FAILURE'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:198:  [TestCheckStyle.test_failures_no_style_issues] Undefined variable 'CheckStyle'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:210:  [TestCheckStyle.test_failures_no_style_issues] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:210:  [TestCheckStyle.test_failures_no_style_issues] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:210:  [TestCheckStyle.test_failures_no_style_issues] Undefined variable 'SUCCESS'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:214:  [TestCheckStyle.test_failures_no_changes] Undefined variable 'CheckStyle'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:226:  [TestCheckStyle.test_failures_no_changes] Passing unexpected keyword argument 'state_string' in function call  [pylint/E1123] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:226:  [TestCheckStyle.test_failures_no_changes] No value passed for parameter 'status_text' in function call  [pylint/E1120] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:226:  [TestCheckStyle.test_failures_no_changes] Undefined variable 'FAILURE'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:24:  No name 'results' in module 'buildbot.process'  [pylint/E0611] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:27:  No name 'internet' in module 'twisted'  [pylint/E0611] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:35:  [ConfigureBuild.__init__] Use of super on an old style class  [pylint/E1002] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/steps.py:60:  [CheckOutSource.__init__] Use of super on an old style class  [pylint/E1002] [5]
Total errors found: 34 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 EWS Watchlist 2018-06-23 10:54:00 PDT Comment hidden (obsolete)

Comment on attachment 343413 [details]
Proposed patch

Attachment 343413 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8305813

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html

Comment 4 EWS Watchlist 2018-06-23 10:54:11 PDT Comment hidden (obsolete)

Created attachment 343443 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Comment 5 Lucas Forschler 2018-06-25 12:24:06 PDT

Comment on attachment 343413 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343413&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:38
> +        if platform != 'jsc-only':

do we expect to have this for EWS?

Comment 6 Lucas Forschler 2018-06-25 12:24:28 PDT

please address any style check issues before landing.

Comment 7 Aakash Jain 2018-06-25 12:55:37 PDT

View in context: https://bugs.webkit.org/attachment.cgi?id=343413&action=review

>> Tools/BuildSlaveSupport/ews-build/steps.py:38
>> +        if platform != 'jsc-only':
> 
> do we expect to have this for EWS?
long-term plan is to share the code between build.webkit.org and ews-build.webkit.org (once we upgrade build.webkit.org to latest buildbot).
While writing this code I am keeping build.webkit.org in mind.


> please address any style check issues before landing.
Sure, although most of them are false positive.

Comment 8 Aakash Jain 2018-06-25 13:01:50 PDT

Committed r233166: <https://trac.webkit.org/changeset/233166>

Comment 9 Radar WebKit Bug Importer 2018-06-25 13:08:46 PDT

<rdar://problem/41436534>