Bug 186945

Summary: [Fullscreen] Restore ASSERT_NOT_REACHED() checks in exit fullscreen handler after r231924
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Frédéric Wang Nélar <fred.wang>
Status: REOPENED    
Severity: Normal CC: commit-queue, eric.carlson, fred.wang, jeremyj-wk, ryanhaddad, simon.fraser, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 185699, 187300    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Jer Noble
Reported 2018-06-22 15:45:23 PDT
[Fullscreen] Restore ASSERT_NOT_REACHED() checks in exit fullscreen handler after r231924
Attachments
Patch (2.94 KB, patch)
2018-06-22 15:49 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2018-06-22 15:45:56 PDT
<rdar://problem/37277469>
Jer Noble
Comment 2 2018-06-22 15:49:21 PDT
Created attachment 343383 [details] Patch
WebKit Commit Bot
Comment 3 2018-06-22 17:15:58 PDT
Comment on attachment 343383 [details] Patch Clearing flags on attachment: 343383 Committed r233112: <https://trac.webkit.org/changeset/233112>
WebKit Commit Bot
Comment 4 2018-06-22 17:15:59 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 5 2018-07-03 13:40:41 PDT
Re-opened since this is blocked by bug 187300
Truitt Savell
Comment 6 2018-07-03 14:01:15 PDT
*** Bug 187293 has been marked as a duplicate of this bug. ***
Ryan Haddad
Comment 7 2018-07-03 14:02:15 PDT
*** Bug 182527 has been marked as a duplicate of this bug. ***
Frédéric Wang Nélar
Comment 8 2026-10-10 01:57:15 PDT
The code has changed a lot but we still log failure of exitFullScreenAnimated without assert: https://searchfox.org/wubkat/search?q=exitFullScreenAnimated&path=&case=false&regexp=false Maybe that's something we still want to try.
Frédéric Wang Nélar
Comment 9 2026-10-10 02:04:50 PDT
Pull request: https://github.com/WebKit/WebKit/pull/76583
Note You need to log in before you can comment on or make changes to this bug.