| Summary: | Expose colorFilterEnabled SPI in WKPreferencesPrivate | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Luming Yin <luming_yin> | ||||||
| Component: | WebKit API | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, luming_yin, realdawei, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Luming Yin
2018-06-22 11:55:16 PDT
Created attachment 343350 [details] Patch for bug 186935. Comment on attachment 343350 [details] Patch for bug 186935. View in context: https://bugs.webkit.org/attachment.cgi?id=343350&action=review > Source/WebKit/UIProcess/API/Cocoa/WKPreferencesPrivate.h:140 > +@property (nonatomic, setter=_setColorFilterEnabled:) BOOL _colorFilterEnabled WK_API_AVAILABLE(macosx(WK_MAC_TBA)); Needs WK_IOS_TBA Created attachment 343351 [details] Updated patch for bug 186935. Comment on attachment 343351 [details] Updated patch for bug 186935. Clearing flags on attachment: 343351 Committed r233089: <https://trac.webkit.org/changeset/233089> All reviewed patches have been landed. Closing bug. Looks like this patch broke the iOS build sample output: https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Release%20%28Build%29/builds/6738/steps/compile-webkit/logs/stdio ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/slave/ios-simulator-11-release/build/WebKitBuild/WebKit.build/Release-iphonesimulator/WebKit.build/Objects-normal/x86_64/WKPreferences-77E55B3F73300247.o UIProcess/API/Cocoa/WKPreferences.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) I’ll fix it. Build fix in https://trac.webkit.org/changeset/233094/webkit |