Bug 186921

Summary:

[GStreamer] Remove useless workaround

Product:

WebKit

Reporter:

Philippe Normand <pnormand>

Component:

Platform

Assignee:

Philippe Normand <pnormand>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, commit-queue, ews-watchlist, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

187046

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews117 for mac-sierra	none
Archive of layout-test-results from ews202 for win-future	none
Patch	calvaris: review+

Description Philippe Normand 2018-06-22 08:26:51 PDT

In bug 67407 a workaround was added for GStreamer 0.10. With 1.x the media/video-reverse-play-duration.html test passes without any workaround needed. The other test mentioned in that bug was removed, it seems.

Comment 1 Philippe Normand 2018-06-22 08:28:47 PDT

Created attachment 343326 [details]
Patch

Comment 2 EWS Watchlist 2018-06-22 11:49:22 PDT

Comment on attachment 343326 [details]
Patch

Attachment 343326 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/8293239

New failing tests:
performance-api/performance-observer-no-document-leak.html

Comment 3 EWS Watchlist 2018-06-22 11:49:23 PDT

Created attachment 343349 [details]
Archive of layout-test-results from ews117 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-sierra  Platform: Mac OS X 10.12.6

Comment 4 EWS Watchlist 2018-06-23 16:40:09 PDT

Comment on attachment 343326 [details]
Patch

Attachment 343326 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8307969

New failing tests:
http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html

Comment 5 EWS Watchlist 2018-06-23 16:40:20 PDT

Created attachment 343458 [details]
Archive of layout-test-results from ews202 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

Comment 6 Philippe Normand 2018-06-25 03:59:12 PDT

Committed r233143: <https://trac.webkit.org/changeset/233143>

Comment 7 Radar WebKit Bug Importer 2018-06-25 04:01:53 PDT

<rdar://problem/41420581>

Comment 8 WebKit Commit Bot 2018-06-26 08:25:20 PDT

Re-opened since this is blocked by bug 187046

Comment 9 Philippe Normand 2018-07-05 02:23:13 PDT

media/video-ended-event-negative-playback.html breaks with this patch applied because

currentMediaTime() chains to playbackPosition() which returns duration when EOS is reached, without running a POSITION query or checking the direction of playback.

Comment 10 Philippe Normand 2018-07-06 04:57:05 PDT

Created attachment 344421 [details]
Patch

Comment 11 Philippe Normand 2018-07-09 01:15:59 PDT

Committed r233637: <https://trac.webkit.org/changeset/233637>