| Summary: | [GTK] WebDriver: use a dictionary for session capabilities in StartAutomationSession message | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
| Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bugs-noreply, calvaris, ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, saam, zan | ||||
| Priority: | P2 | Keywords: | Gtk | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 343320 [details]
Patch
Attachment 343320 [details] did not pass style-queue:
ERROR: Source/WebDriver/glib/SessionHostGlib.cpp:287: Extra space before ( in function call [whitespace/parens] [4]
Total errors found: 1 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r233077: <https://trac.webkit.org/changeset/233077> |
Instead of growing the message signature every we add a new capability, use a dictionary a{sv} and simply add new entries when new capabilities are added. This way we won't need to change the message signature anymore. This broke the test webkit/WebKitAutomationSession/request-session because we changed the signature twice but we didn't update the test.