Bug 186914

Summary: [WPE][ThreadedRendering] WPE crashes rendering SVG content when using ThreadedRendering
Product: WebKit Reporter: Miguel Gomez <magomez>
Component: WPE WebKitAssignee: Miguel Gomez <magomez>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, cgarcia, commit-queue, ews-watchlist, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews100 for mac-sierra
none
Patch
none
Archive of layout-test-results from ews114 for mac-sierra none

Miguel Gomez
Reported 2018-06-22 02:02:21 PDT
Some SVG content uses GraphicsContext::clipToImageBuffer to define a clipping from the contents of an ImageBuffer. But GraphicsContextImpl doesn't have an implementation for this method so the call cannot be delegated and recorded. Instead, cairo GraphicsContext tries to perform cairo operations while in the recording state which causes the crash.
Attachments
Patch (8.44 KB, patch)
2018-06-22 02:22 PDT, Miguel Gomez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-sierra (2.28 MB, application/zip)
2018-06-22 03:29 PDT, EWS Watchlist 		no flags
Details
Patch (8.50 KB, patch)
2018-06-22 04:55 PDT, Miguel Gomez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews114 for mac-sierra (3.00 MB, application/zip)
2018-06-22 06:30 PDT, EWS Watchlist 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Miguel Gomez
Comment 1 2018-06-22 02:22:23 PDT
Created attachment 343315 [details] Patch
EWS Watchlist
Comment 2 2018-06-22 03:29:05 PDT
Comment on attachment 343315 [details] Patch Attachment 343315 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/8288431 New failing tests: performance-api/performance-observer-no-document-leak.html
EWS Watchlist
Comment 3 2018-06-22 03:29:06 PDT
Created attachment 343317 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Miguel Gomez
Comment 4 2018-06-22 04:55:00 PDT
Created attachment 343318 [details] Patch
EWS Watchlist
Comment 5 2018-06-22 06:30:35 PDT
Comment on attachment 343318 [details] Patch Attachment 343318 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/8289544 New failing tests: performance-api/performance-observer-no-document-leak.html
EWS Watchlist
Comment 6 2018-06-22 06:30:37 PDT
Created attachment 343323 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6
WebKit Commit Bot
Comment 7 2018-06-22 07:02:36 PDT
Comment on attachment 343318 [details] Patch Clearing flags on attachment: 343318 Committed r233078: <https://trac.webkit.org/changeset/233078>
WebKit Commit Bot
Comment 8 2018-06-22 07:02:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.