Bug 186899

Summary: Web Automation: key actions should support multiple pressed virtual keys
Product: WebKit Reporter: BJ Burg <bburg>
Component: WebDriverAssignee: BJ Burg <bburg>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, cgarcia, ews-watchlist, joepeck, mcatanzaro, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed Fix
none
Patch (fix EWS)
timothy: review+, ews-watchlist: commit-queue-
Archive of layout-test-results from ews122 for ios-simulator-wk2 none

Description BJ Burg 2018-06-21 15:53:49 PDT 
Right now, only one virtual key can be specified for an action keyframe. This prevents encoding a chord like Shift+Ctrl+A which has more than one modifier, or a sticky modifier with another key like F1 that's encoded as a VirtualKey in the protocol.
Comment 1 BJ Burg 2018-06-21 16:03:47 PDT 
<rdar://problem/38222248>
Comment 2 BJ Burg 2018-06-21 16:46:12 PDT 
Created attachment 343289 [details]
Proposed Fix

Needs to be landed with internal changes.
Comment 3 BJ Burg 2018-06-22 09:25:39 PDT 
Created attachment 343331 [details]
Patch (fix EWS)
Comment 4 EWS Watchlist 2018-06-22 10:58:03 PDT 
Comment on attachment 343331 [details]
Patch (fix EWS)

Attachment 343331 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/8292088

New failing tests:
performance-api/performance-observer-no-document-leak.html
Comment 5 EWS Watchlist 2018-06-22 10:58:05 PDT 
Created attachment 343346 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.4
Comment 6 BJ Burg 2018-06-23 12:17:14 PDT 
Committed r233131: <https://trac.webkit.org/changeset/233131>
Comment 7 Michael Catanzaro 2018-06-24 09:59:59 PDT 
Committed r233133: <https://trac.webkit.org/changeset/233133>