| Summary: | ensureWritableX should only convert away from CoW when it will succeed | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||
| Component: | JavaScriptCore | Assignee: | Saam Barati <saam> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Saam Barati
2018-06-21 15:09:17 PDT
Created attachment 343288 [details]
patch
Comment on attachment 343288 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=343288&action=review > Source/JavaScriptCore/runtime/JSObject.cpp:1482 > + if (hasInt32(indexingMode())) { Nit I would do: leastUpperBoundOfIndexingTypes(indexingType() & IndexingShapeMask, Int32Shape) == Int32Shape > Source/JavaScriptCore/runtime/JSObject.cpp:1517 > + if (hasDouble(indexingMode()) || hasInt32(indexingMode())) { Nit I would do: leastUpperBoundOfIndexingTypes(indexingType() & IndexingShapeMask, DoubleShape) == DoubleShape > Source/JavaScriptCore/runtime/JSObject.cpp:1556 > + if (hasContiguous(indexingMode()) || hasInt32(indexingMode()) || hasDouble(indexingMode())) { Nit I would do: leastUpperBoundOfIndexingTypes(indexingType() & IndexingShapeMask, ContiguousShape) == ContiguousShape r=me Created attachment 343290 [details]
patch for landing
Comment on attachment 343290 [details] patch for landing Clearing flags on attachment: 343290 Committed r233098: <https://trac.webkit.org/changeset/233098> All reviewed patches have been landed. Closing bug. |