Bug 186886

Summary: [WPE][ThreadedRendering] WPE crashes rendering some pieces of text when using ThreadedRendering
Product: WebKit Reporter: Miguel Gomez <magomez>
Component: WPE WebKitAssignee: Miguel Gomez <magomez>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, calvaris, commit-queue, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Miguel Gomez 2018-06-21 03:25:46 PDT 
As an optimization, FontCascade may render some glyphs to a DisplayList and then replay that list instead of rendering again. But when replaying, the glyphs are not rendered through a GraphicsContext as we would expect, but using FontCascade directly. In the cairo case this means that FontCascade requires a cairo context to render, but if we are in the recording phase of the rendering there's no platform context and we have the crash.
Comment 1 Miguel Gomez 2018-06-21 03:34:51 PDT 
Created attachment 343231 [details]
Patch
Comment 2 Miguel Gomez 2018-06-22 01:03:45 PDT 
Created attachment 343313 [details]
Patch
Comment 3 WebKit Commit Bot 2018-06-22 02:50:01 PDT 
Comment on attachment 343313 [details]
Patch

Clearing flags on attachment: 343313

Committed r233075: <https://trac.webkit.org/changeset/233075>
Comment 4 WebKit Commit Bot 2018-06-22 02:50:03 PDT 
All reviewed patches have been landed.  Closing bug.