| Summary: | [GTK] WebDriver: allow applying host-specific TLS certificates for automated sessions | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||
| Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bburg, berto, cgarcia, ews-watchlist, gustavo, joepeck, keith_miller, mark.lam, mcatanzaro, msaboff, saam, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Zan Dobersek
2018-06-21 03:00:16 PDT
Created attachment 343229 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 343229 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343229&action=review > Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorServer.cpp:135 > + while (g_variant_iter_loop(certificates.get(), "(ss)", &host, &certificateFile)) You are getting copies here, you need to use "(&s&s)" Committed r233035: <https://trac.webkit.org/changeset/233035> |