Bug 186876

Summary:

Add force schedulers to OpenSource EWS Buildbot

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, dean_johnson, ews-watchlist, lforschler, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=196444

Attachments:

Description	Flags
Proposed patch	lforschler: review+

Description Aakash Jain 2018-06-20 20:58:42 PDT

Builders on OpenSource EWS (e.g.: http://ews-build.webkit-uat.org/#/builders/5) currently do not have force schedulers, that's why there is no button on UI (webpage) to start a build. We should add force schedulers. This would help in testing and development as well as occasionally useful for forcing a build on a particular revision.

This would be similar to what we do in other similar Buildbot code for pre-commit testing.

Comment 1 Aakash Jain 2018-06-20 21:11:42 PDT

Created attachment 343210 [details]
Proposed patch

Comment 2 EWS Watchlist 2018-06-20 21:13:07 PDT Comment hidden (obsolete)

Attachment 343210 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/loadConfig.py:28:  No name 'WorkerChoiceParameter' in module 'buildbot.schedulers.forcesched'  [pylint/E0611] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Aakash Jain 2018-06-21 11:55:22 PDT

Committed r233045: <https://trac.webkit.org/changeset/233045>

Comment 4 Radar WebKit Bug Importer 2018-06-21 11:57:38 PDT

<rdar://problem/41338094>