| Summary: | [Cocoa] Use the isDirectory: variants of NSURL methods more to eliminate unnecessary file system activity | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||
| Component: | WebKit Misc. | Assignee: | Darin Adler <darin> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | andersca, conrad_shultz, ews-watchlist, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Darin Adler
2018-06-20 20:16:37 PDT
Created attachment 343208 [details]
Patch
Comment on attachment 343208 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343208&action=review Looks good to me, though I can't r+. > Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:3962 > + if (![wrapper writeToURL:[NSURL fileURLWithPath:path isDirectory:NO] options:NSFileWrapperWritingWithNameUpdating originalContentsURL:nil error:nullptr]) A few lines earlier, we use `m_promisedURL` when initializing the file wrapper, but use the plain `+URLWithString:`. It seems like `m_promisedURL` must also be a file URL, so should that be changed? Since this is apparently used only for saving images, this change seems correct, but I'm a little wary since file wrappers can refer to directories. Comment on attachment 343208 [details] Patch Attachment 343208 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/8275207 New failing tests: http/tests/security/canvas-remote-read-remote-video-blocked-no-crossorigin.html Created attachment 343228 [details]
Archive of layout-test-results from ews202 for win-future
The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Committed r233079: <https://trac.webkit.org/changeset/233079> |