| Summary: | JSPerformanceObserverCallback creates a GC strongly-referenced Function that is never cleaned up | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||
| Component: | Bindings | Assignee: | Chris Dumez <cdumez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, esprehn+autocc, ews-watchlist, ggaren, joepeck, keith_miller, kondapallykalyan, mark.lam, realdawei, saam, sam, simon.fraser, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=215158 | ||||||||
| Bug Depends on: | 186938 | ||||||||
| Bug Blocks: | |||||||||
| Attachments: |
|
||||||||
|
Description
Chris Dumez
2018-06-20 19:53:25 PDT
Created attachment 343205 [details]
Patch
Comment on attachment 343205 [details]
Patch
Nice but can we also add a test that the Document is not permanently leaked?
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 343205 [details] > Patch > > Nice but can we also add a test that the Document is not permanently leaked? Sure, how do I do that? (In reply to Chris Dumez from comment #4) > (In reply to Simon Fraser (smfr) from comment #3) > > Comment on attachment 343205 [details] > > Patch > > > > Nice but can we also add a test that the Document is not permanently leaked? > > Sure, how do I do that? Just found internals.numberOfLiveDocuments(), will try this. Created attachment 343247 [details]
Patch
Comment on attachment 343247 [details] Patch Clearing flags on attachment: 343247 Committed r233053: <https://trac.webkit.org/changeset/233053> All reviewed patches have been landed. Closing bug. Looks like test performance-api/performance-observer-no-document-leak.html is timing out on all platforms: Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=performance-api%2Fperformance-observer-no-document-leak.html Sample results: https://build.webkit.org/builders/Apple%20High%20Sierra%20Release%20WK1%20(Tests)/builds/6137/steps/layout-test/logs/stdio Regressions: Unexpected timeouts (1) performance-api/performance-observer-no-document-leak.html [ Timeout ] |