| Summary: | Add support for using localhost worker in OpenSource EWS Buildbot | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, ap, dean_johnson, ews-watchlist, lforschler, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=224551 | ||||||||
| Attachments: |
|
||||||||
|
Description
Aakash Jain
2018-06-20 19:22:28 PDT
Created attachment 343200 [details]
Proposed patch
Comment on attachment 343200 [details] Proposed patch Attachment 343200 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/8272582 New failing tests: imported/w3c/web-platform-tests/workers/semantics/structured-clone/dedicated.html Created attachment 343211 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.4
Comment on attachment 343200 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=343200&action=review > Tools/BuildSlaveSupport/ews-build/master.cfg:4 > Can you put this in sorted order? > Can you put this in sorted order? This was not sorted intentionally, in order to separate standard library import from and importing our files. Similar to what we do in other places, e.g.: https://trac.webkit.org/browser/webkit/trunk/Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py#L31 https://www.python.org/dev/peps/pep-0008/#imports PEP8: Imports should be grouped in the following order: Standard library imports. Related third party imports. Local application/library specific imports. Committed r233047: <https://trac.webkit.org/changeset/233047> |