Bug 186867

Summary: Web Inspector: All non-Same-Site cookies are marked as Same-Site Strict in Storage tab
Product: WebKit Reporter: Daniel Bates <dbates>
Component: Web InspectorAssignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: inspector-bugzilla-changes, mattbaker, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch mattbaker: review+

Description Daniel Bates 2018-06-20 16:46:54 PDT 
Steps to reproduce:

1. Open a new browser window and open Web Inspector to the storage tab.
2. Visit http://gmail.com.
3. Login.
4. In Web Inspector, click Cookies form the right-hand side.

At the time of writing there should be exactly two cookies GMAIL_RTT and GAPS that are not same-site cookies. That is the value of the Same-Site column should be empty.
Comment 1 Daniel Bates 2018-06-20 16:47:11 PDT 
<rdar://problem/41175424>
Comment 2 Daniel Bates 2018-06-20 16:58:46 PDT 
Created attachment 343192 [details]
Patch
Comment 3 Matt Baker 2018-06-20 17:03:39 PDT 
Comment on attachment 343192 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343192&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js:143
> +                sameSite: !cookie.sameSite || cookie.sameSite === WI.Cookie.SameSiteType.None ? "" : WI.Cookie.displayNameForSameSiteType(cookie.sameSite),

I think this reads better as:

sameSite: cookie.sameSite && cookie.sameSite !== WI.Cookie.SameSiteType.None ? WI.Cookie.displayNameForSameSiteType(cookie.sameSite) : "",
Comment 4 Daniel Bates 2018-06-20 17:09:12 PDT 
Committed r233027: <https://trac.webkit.org/changeset/233027>