Bug 186860

Summary: [WebKit on watchOS] Fixed position elements sometimes flicker when scrolling
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebKit Misc.Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
thorton: review+
Patch for landing none

Description Wenson Hsieh 2018-06-20 14:08:55 PDT
<rdar://problem/39953563>
Comment 1 Wenson Hsieh 2018-06-20 14:42:30 PDT
Created attachment 343182 [details]
Patch
Comment 2 Tim Horton 2018-06-20 16:03:03 PDT
Comment on attachment 343182 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=343182&action=review

> Tools/TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:57
> +    sleep(1);

:( quite a slow API test. but I can't imagine a better way without e.g. overriding internal methods on WKWebView.
Comment 3 Wenson Hsieh 2018-06-20 16:04:24 PDT
(In reply to Tim Horton from comment #2)
> Comment on attachment 343182 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=343182&action=review
> 
> > Tools/TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:57
> > +    sleep(1);
> 
> :( quite a slow API test. but I can't imagine a better way without e.g.
> overriding internal methods on WKWebView.

True, 1 sec. is somewhat excessive. I'll tone it down.
Comment 4 Wenson Hsieh 2018-06-20 16:18:47 PDT
Created attachment 343187 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2018-06-20 16:57:28 PDT
Comment on attachment 343187 [details]
Patch for landing

Clearing flags on attachment: 343187

Committed r233025: <https://trac.webkit.org/changeset/233025>