| Summary: | [Fullscreen] Suspend page (and pause video) while phishing warining is presented | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||||
| Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, eric.carlson, jeremyj-wk, jonlee, thorton, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Jer Noble
2018-06-20 10:56:58 PDT
Created attachment 343164 [details]
Patch
Comment on attachment 343164 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=343164&action=review > Source/WebKit/ChangeLog:3 > + [Fullscreen] Suspend page (and pause video) while phishing warining is presented warining? > Source/WebCore/html/HTMLMediaElement.cpp:5603 > + m_shouldUnpauseInternalOnResume = true; > + setPausedInternal(true); This could use an explanation in the changelog. > Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:453 > + page->suspendActiveDOMObjectsAndAnimations(); Should we also suspend/defer layer tree commits? Is this enough to actually stop painting? Do you even care? Created attachment 343249 [details]
Patch for landing
(In reply to Tim Horton from comment #3) > Comment on attachment 343164 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=343164&action=review > > > Source/WebKit/ChangeLog:3 > > + [Fullscreen] Suspend page (and pause video) while phishing warining is presented > > warining? Changed. > > Source/WebCore/html/HTMLMediaElement.cpp:5603 > > + m_shouldUnpauseInternalOnResume = true; > > + setPausedInternal(true); > > This could use an explanation in the changelog. Added. > > Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:453 > > + page->suspendActiveDOMObjectsAndAnimations(); > > Should we also suspend/defer layer tree commits? Is this enough to actually > stop painting? Do you even care? No, this should be sufficient; JS stops running as a result of this call, so between that and video playback pausing, that should be keep anything from painting. Created attachment 343250 [details]
Patch for landing
Comment on attachment 343250 [details] Patch for landing Clearing flags on attachment: 343250 Committed r233049: <https://trac.webkit.org/changeset/233049> All reviewed patches have been landed. Closing bug. Reopening to attach new patch. Created attachment 357608 [details]
Patch
|