Bug 186826

Summary: [Fullscreen] Exit fullscreen when opening a new tab
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, ews-watchlist, jeremyj-wk, jonlee, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews104 for mac-sierra-wk2
none
Archive of layout-test-results from ews204 for win-future none

Description Jer Noble 2018-06-19 16:38:56 PDT
[Fullscreen] Exit fullscreen when opening a new tab
Comment 1 Jer Noble 2018-06-19 16:39:18 PDT
<rdar://problem/40853211>
Comment 2 Jer Noble 2018-06-19 16:41:47 PDT
Created attachment 343120 [details]
Patch
Comment 3 EWS Watchlist 2018-06-19 20:31:04 PDT
Comment on attachment 343120 [details]
Patch

Attachment 343120 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/8259914

New failing tests:
accessibility/mac/selection-notification-focus-change.html
Comment 4 EWS Watchlist 2018-06-19 20:31:06 PDT
Created attachment 343130 [details]
Archive of layout-test-results from ews104 for mac-sierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-sierra-wk2  Platform: Mac OS X 10.12.6
Comment 5 EWS Watchlist 2018-06-20 18:11:42 PDT
Comment on attachment 343120 [details]
Patch

Attachment 343120 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/8271037

New failing tests:
http/tests/security/video-poster-cross-origin-crash2.html
Comment 6 EWS Watchlist 2018-06-20 18:11:53 PDT
Created attachment 343198 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment 7 Brent Fulgham 2018-06-22 12:53:33 PDT
Comment on attachment 343120 [details]
Patch

r=me. The test flakiness seems unrelated to this change.
Comment 8 WebKit Commit Bot 2018-06-22 13:25:02 PDT
Comment on attachment 343120 [details]
Patch

Clearing flags on attachment: 343120

Committed r233095: <https://trac.webkit.org/changeset/233095>
Comment 9 WebKit Commit Bot 2018-06-22 13:25:03 PDT
All reviewed patches have been landed.  Closing bug.