Bug 186748

Summary:

QueueStatusServer: "'NoneType' object has no attribute 'message'" in ReleasePatch.get() when attachment is skipped by queue

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, ews-watchlist, glenn, lforschler, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

186291

Attachments:

Description	Flags
Patch	none
Patch and unit tests	none

Description Daniel Bates 2018-06-16 18:28:24 PDT

QueueStatusServer: "'NoneType' object has no attribute 'message'" in ReleasePatch.get() when attachment is skipped by queue.

The backtrace has the form:

'NoneType' object has no attribute 'message'
Traceback (most recent call last):
File "/.../webapp2.py", line 1511, in __call__
rv = self.handle_exception(request, response, e)
File "/.../webapp2.py", line 1505, in __call__
rv = self.router.dispatch(request, response)
File "/.../webapp2.py", line 1253, in default_dispatcher
return route.handler_adapter(request, response)
File "/.../webapp2.py", line 1077, in __call__
return handler.dispatch()
File "/.../webapp2.py", line 547, in dispatch
return self.handle_exception(e, self.app.debug)
File "/.../webapp2.py", line 545, in dispatch
return method(*args, **kwargs)
File "/.../handlers/releasepatch.py", line 59, in post
RecordPatchEvent.stopped(attachment_id, queue_name, last_status.message)
AttributeError: 'NoneType' object has no attribute 'message'

Comment 1 Daniel Bates 2018-06-16 18:29:30 PDT

Created attachment 342902 [details]
Patch

Comment 2 EWS Watchlist 2018-06-16 18:31:13 PDT

Attachment 342902 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:10:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: security bug, security bug  [changelog/unwantedsecurityterms] [3]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Daniel Bates 2018-06-16 22:29:41 PDT

Created attachment 342905 [details]
Patch and unit tests

Comment 4 Daniel Bates 2018-06-19 12:39:57 PDT

Comment on attachment 342905 [details]
Patch and unit tests

Clearing flags on attachment: 342905

Committed r232973: <https://trac.webkit.org/changeset/232973>

Comment 5 Daniel Bates 2018-06-19 12:39:59 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Radar WebKit Bug Importer 2018-06-19 12:40:45 PDT

<rdar://problem/41259861>

Comment 7 Daniel Bates 2018-06-22 17:41:04 PDT

*** Bug 171463 has been marked as a duplicate of this bug. ***